Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-37434 patch #13

Closed
wants to merge 1 commit into from
Closed

CVE-2022-37434 patch #13

wants to merge 1 commit into from

Conversation

jharlow-intel
Copy link

@AndresGuzman-Ballen
Copy link

@katietz @tobijk @chenghlee @remkade Can we merge this asap? Unfortunately, this CVE has a rating of 9.8 :(

@AndresGuzman-Ballen
Copy link

@jharlow-intel thanks for the PR!

@AndresGuzman-Ballen
Copy link

Friendly ping :)

@tobijk tobijk added the build label Aug 18, 2022
@tobijk
Copy link

tobijk commented Aug 18, 2022

Looks like we need to tweak the patch to apply cleanly.

@AndresGuzman-Ballen
Copy link

@tobijk Thanks for replying! :O oh no! I'll see what needs to get done asap!

@AndresGuzman-Ballen
Copy link

Since I don't have write-permissions to downstream repo, I created another PR with the tweak: #14

@tobijk
Copy link

tobijk commented Aug 19, 2022

There are some reservations here about applying this patch as is after this issue with libcurl turned up.

@AndresGuzman-Ballen
Copy link

@tobijk actually, we didn't get the original patch for that reason (which is why the patch had not cleanly applied). This patch actually includes the fix that had appeared in libcurl: madler/zlib@1eb7682. Hopefully that addresses some concerns.

@remkade
Copy link

remkade commented Aug 19, 2022

We would like to do some internal testing and validation before applying a patch here. We're monitoring a few external discussions that make us want to be cautious.

@AndresGuzman-Ballen
Copy link

@remkade sounds like a plan!

@chenghlee
Copy link

Closing; superseded by #15

@chenghlee chenghlee closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants