Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve openPMD diagnostics #81

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Improve openPMD diagnostics #81

merged 6 commits into from
Jul 11, 2022

Conversation

AngelFP
Copy link
Owner

@AngelFP AngelFP commented Jul 11, 2022

  • Include all components of E and B (i.e., r, t and z) in the openPMD output, even if they are zero. This improves compatibility with post-processing tools such as the openPMD viewer.
  • Set the correct units of the B field. Currently no units were set, as the diagnostics still expected the transverse wakefield W instead of E and B.
  • In the Tracker, update the tracking time before updating the next object. This makes sure, for example, that the openPMD diagnostics have the correct updated time.
  • In the ParticleBunch, use the current global time instead of prop_distance to calculate the z offset. This makes sure that the beam does not jitter in z in the openPMD diagnostics if the beam push and diagnostics do not occur at the same time.

In addition:

  • Pass the correct current time of the bunch when pushing it.
  • Update tests so that they pass after this fix.

@AngelFP AngelFP merged commit aa6b73c into dev Jul 11, 2022
@AngelFP AngelFP deleted the improve_diagnostics branch July 11, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant