Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Fix for duplicate toast containers
title: '[PR] '
labels: ''
assignees: ''
Related Issue
Mentioned in the FastHTML discord by user
78wesley
and validated locally.Proposed Changes
Toast containers were being spawned in overlapping contexts and thus rendering incorrectly when using multiple
add_toast
methods.I've been through the gist provided by 78wesley in the discord, and it did indeed fix the issue. I've done a cleanup/ revamp of the
toaster.py
file to fix the issues, and also removed the javascript in favour of htmx.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply:Demo
toast_fix_final.mp4