Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jinaai-reranker-v2-base-multiligual #84

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lywa1998
Copy link
Contributor

This PR adds the Jina reranker v2 model, along with test code for this model.

@Anush008
Copy link
Owner

Anush008 commented Jul 23, 2024

Thank you @lywa1998. LGTM 👍👍

@Anush008 Anush008 merged commit 304fe63 into Anush008:main Jul 23, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
# [3.10.0](v3.9.1...v3.10.0) (2024-07-23)

### Features

* add jinaai-reranker-v2-base-multiligual ([#84](#84)) ([304fe63](304fe63))

## [3.10.0](v3.9.1...v3.10.0) (2024-07-23)

### 🍕 Features

* add jinaai-reranker-v2-base-multiligual ([#84](#84)) ([304fe63](304fe63))
Copy link

🎉 This issue has been resolved in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -4,6 +4,8 @@ pub enum RerankerModel {
BGERerankerBase,
// jinaai/jina-reranker-v1-turbo-en
JINARerankerV1TurboEn,
// jinaai/jina-reranker-v2-base-multilingual
JINARerankerV2BaseMultiligual,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. Just noticed.
These 2 should've been doc comments like the first.
///

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I was simply following the previous JINA model setup and didn't notice this. I look forward to seeing the changes in the next release.

mcmah309 pushed a commit to mcmah309/fastembed-rs that referenced this pull request Jul 27, 2024
mcmah309 pushed a commit to mcmah309/fastembed-rs that referenced this pull request Jul 27, 2024
# [3.10.0](Anush008/fastembed-rs@v3.9.1...v3.10.0) (2024-07-23)

### Features

* add jinaai-reranker-v2-base-multiligual ([Anush008#84](Anush008#84)) ([304fe63](Anush008@304fe63))

## [3.10.0](Anush008/fastembed-rs@v3.9.1...v3.10.0) (2024-07-23)

### 🍕 Features

* add jinaai-reranker-v2-base-multiligual ([Anush008#84](Anush008#84)) ([304fe63](Anush008@304fe63))
Anush008 pushed a commit that referenced this pull request Jul 27, 2024
* feat: Allow working offline

* fix: Fix docs and tests for when feature is disabled

* chore: Add CI offline test

* refactor: Formatting

* feat: add jinaai-reranker-v2-base-multiligual (#84)

add jinaai-reranker-v2-base-multiligual

* chore(release): 3.10.0 [skip ci]

# [3.10.0](v3.9.1...v3.10.0) (2024-07-23)

### Features

* add jinaai-reranker-v2-base-multiligual ([#84](#84)) ([304fe63](304fe63))

## [3.10.0](v3.9.1...v3.10.0) (2024-07-23)

### 🍕 Features

* add jinaai-reranker-v2-base-multiligual ([#84](#84)) ([304fe63](304fe63))

* feat: Add ort load-dynamic feature (#87)

* fix: Signify new test as online only

* chore: Resolve rebase

---------

Co-authored-by: Riddler <35594786+lywa1998@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 27, 2024
# [3.11.0](v3.10.0...v3.11.0) (2024-07-27)

### Features

* Add offline support ([#89](#89)) ([78a4182](78a4182)), closes [#84](#84) [#84](#84) [#84](#84) [#87](#87)
* Add ort load-dynamic feature ([#87](#87)) ([5dbb326](5dbb326))

## [3.11.0](v3.10.0...v3.11.0) (2024-07-27)

### 🍕 Features

* Add offline support ([#89](#89)) ([78a4182](78a4182)), closes [#84](#84) [#84](#84) [#84](#84) [#87](#87)
* Add ort load-dynamic feature ([#87](#87)) ([5dbb326](5dbb326))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants