Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI #2497

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix broken CI #2497

merged 1 commit into from
Feb 14, 2025

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Feb 14, 2025

Remove dotnet-validate from .NET tools manifest to avoid build failure on macOS.

Works around dotnet/sdk#46857.

Remove dotnet-validate from .NET tools manifest to avoid build failure on macOS.
@martincostello martincostello marked this pull request as ready for review February 14, 2025 09:59
@martincostello martincostello enabled auto-merge (rebase) February 14, 2025 09:59
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (4e6f93f) to head (5d28411).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2497   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         312      312           
  Lines        7465     7465           
  Branches     1121     1121           
=======================================
  Hits         6372     6372           
  Misses        908      908           
  Partials      185      185           
Flag Coverage Δ
linux 85.35% <ø> (ø)
macos 85.35% <ø> (ø)
windows 85.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 7ddbd0b into main Feb 14, 2025
24 checks passed
@martincostello martincostello deleted the fix-ci-workaround branch February 14, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant