-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Allows players to reverse the function of '#' and '$' in search #8291
base: main
Are you sure you want to change the base?
[Feature] Allows players to reverse the function of '#' and '$' in search #8291
Conversation
Don't some recipe viewers also have the ability to use any arbitrary symbol for those functions? (I think I have seen this in either REI or EMI, possibly both) It might make sense to have an option to get those symbols from the recipe viewer |
Unfortunately, neither of these recipe viewer mods has been given a configuration option, and currently they only have a ‘search with or without prefix’ option, and custom prefixes are not yet supported. This pull request will be marked as a draft for now and will be re-enabled when the recipe viewer supports this feature. |
imo automatically switching to adjust to the default of the recipe viewers and having the option to switch it in ae2 already is a big improvement, I don't think we should block this PR on other recipe viewers getting the option to adjust this. |
Another problem this pull request contains is that it only considers both # and $. If the recipe viewer supports custom prefixes in the future, is it necessary to support each prefix specifying symbols in advance? |
no, that can be done once it becomes relevant (i.e. once they get the feature, or when it is known they get the feature relatively soon (ie. if there is an open PR for that feature)) |
ce2fbef
to
0fe0547
Compare
0fe0547
to
6670937
Compare
6670937
to
bc1633e
Compare
Upon investigation, there is a difference in how # and $ are handled by different mods:
So a client-side setting is provided to allow players to reverse their functionality, which also automatically assigns defaults based on the item lists mod on first load.