Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline edit modal with parallelism control #77

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

jbeisen
Copy link
Collaborator

@jbeisen jbeisen commented Apr 25, 2023

Add an "Edit" button on the job details page that opens up a modal. The modal contains a form that can be used to change the parallelism.

Resolves: #74


This is a work in progress. Still to do:

  • add more validation to the form
  • indicate on the job details page that the pipeline is restarting
    I guess it already does this?
  • maybe change the design of the restart warning?

The modal:
image

If you change the parallelism value:

image

Copy link
Member

@mwylde mwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

The only issue I noticed is that if you edit the parallelism and hit cancel, re-opening the modal shows the edited parallelism rather than the actual current parallelism (in other words, cancel doesn't reset the state of the modal).

}

const parallelismInput = (
<Input
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a number input?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done. I had to manually set the background color, though. Maybe there's a bug with the dark theme.

Add an "Edit" button on the job details page that opens up a modal. The
modal contains a form that can be used to change the parallelism.

Resolves: #74
@jbeisen jbeisen marked this pull request as ready for review April 26, 2023 04:12
Copy link
Member

@mwylde mwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jbeisen jbeisen merged commit d121ced into master Apr 26, 2023
@jbeisen jbeisen deleted the edit-parallelism branch April 26, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The UI should allow users to change parallelism
2 participants