Fix public bit size in RSA PSS signature check #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the PSS padding to correct length in case modulus bit length is less than 4096. Previously such signatures would crash the verification process.
|
Hi @onesk, great catch, thank you very much! 👏 We need to include it in the next hard fork. |
|
Added here, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the PSS padding to correct length in case modulus bit length is less than 4096 - the byte size should be rounded up, not down.
A test case for this is evidenced in #283. Arweave-js would succesfully verify said signature via crypto.subtle, but Erlang implementation fails to do so. Not only it rejects the perfectly valid signature, it also crashes the verification process.