Repack in place complete console message now includes storage module name #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "the storage module folder to reflect the new packing, and start the " | ||
| "node with the new storage module.~n", []), | ||
| "node with the new storage module.~n", [Label]), |
There was a problem hiding this comment.
I thin we want to output the StoreID rather than the label. The Label is the obfuscated storage module name (with the mining address hidden), but since the console message is only visible to the miner, it's probably more helpful to include the real storage module name (non obfuscated). Like what is included in the LOG_INFO: https://github.com/ArweaveTeam/arweave/pull/635/files#diff-70860f94e3504d0cdd89e58a65a090fadb6a75eabc58f0a89aeae829109e8dbbR768
There was a problem hiding this comment.
Now it should be "Repacking of strorage_module_50_ADDR.1 is complete!"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Untested (because it's way difficult to test that comparing to implementation)