Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node introspection options #651

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add node introspection options #651

merged 1 commit into from
Nov 28, 2024

Conversation

shizzard
Copy link
Collaborator

No description provided.

@shizzard shizzard self-assigned this Nov 27, 2024
Copy link
Collaborator

@JamesPiechota JamesPiechota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @shizzard . I'm not sure I understand the module name user_default though? If it's only only supposed to be used when debugging or introspection... maybe something like introspection.erl or something? As it is, the module sounds important, like it's a core part of the normal node execution.

in any case: since I don't really know how i will be used, I could be off base on the naming! I defer to you what's best.

@shizzard
Copy link
Collaborator Author

Looks good to me @shizzard . I'm not sure I understand the module name user_default though? If it's only only supposed to be used when debugging or introspection... maybe something like introspection.erl or something? As it is, the module sounds important, like it's a core part of the normal node execution.

in any case: since I don't really know how i will be used, I could be off base on the naming! I defer to you what's best.

@JamesPiechota the name is indeed important: docs.
I'll check the shell_default though, I missed that entirely. If those are mutually interchangeable, we can go with shell_default.

@shizzard shizzard merged commit a8dfb4e into master Nov 28, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants