-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quaternion attitude control scripts #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09a3147
to
4d9abdf
Compare
4d9abdf
to
dd01e24
Compare
xdwgood
reviewed
Dec 17, 2018
quaternion_attitude_control/quaternion_attitude_control_test.py
Outdated
Show resolved
Hide resolved
bresch
requested changes
Dec 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Maybe add in the README how to run it, e.g.:
Install dependencies:sudo pip3 install pyquaternion
Run: python3 quaternion_attitude_control_test.py
Or at least mention that it runs on python3 only.
xdwgood
reviewed
Dec 22, 2018
bresch
approved these changes
Dec 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context is in the description of PX4/PX4-Autopilot#11051
I added scripts for the basic calculation and visualization of the quaternion attitude controller:
PX4/PX4-Autopilot#8003
https://github.com/PX4/Firmware/blob/6a5108269e892636826073fd41cbc8eddf57e891/src/modules/mc_att_control/mc_att_control_main.cpp#L543-L599
It's a refactored, pythonized copy of what I used to prototype in Matlab before the controller was introduced. I'm after solving the kind of unexpected results which happen in the cases that is simulated by the test script how it currently is. I'll modularize and enhance the scripts and resolve the case now.