Author Select #328
Author Select #328
Conversation
…select is enabled
There was a problem hiding this comment.
A couple of minor pieces of feedback for you.
Regards LIVEBLOG_ALLOW_AUTHOR_SELECT I'd rather we just enabled it by default. It's not a feature I think we need to make people jump through a hoop for.
Instead of showing it by default, perhaps we introduce a menu of sorts (e.g. perhaps using the 3-dots style menu selector) and have the author and contributor options within there?
| @@ -11,7 +11,13 @@ class WPCOM_Liveblog_Entry { | |||
| * @var string In case the current entry is an edit (replaces) of | |||
| * another entry, we store the other entry's ID in this meta key. | |||
| */ | |||
| const replaces_meta_key = 'liveblog_replaces'; | |||
| const replaces_meta_key = 'liveblog_replaces'; | |||
There was a problem hiding this comment.
Minor, but can we fix the spacing here?
liveblog.php
Outdated
| * Get current user | ||
| */ | ||
| public static function get_current_user() { | ||
| if (!self::is_liveblog_editable()) { |
There was a problem hiding this comment.
Could do with updating the spacing here.
liveblog.php
Outdated
|
|
||
| return array( | ||
| 'id' => $user->ID, | ||
| 'key' => strtolower($user->user_nicename), |
| getUsers(text, callback) { | ||
| const { config } = this.props; | ||
| getAuthors(text, config) | ||
| .timeout(10000) |
There was a problem hiding this comment.
Is this 10,000 seconds? Seems a bit much.
There was a problem hiding this comment.
Milliseconds, so its 10 seconds :)
|
@philipjohn That sounds like a good idea 👍 We'll see what we can come up with. |
…tions behind a dropdown
|
I feel like the UI could be prettier, but it does the job. If we end up with a need for more options in future, we can move to a more discrete UI element. One issue - when selecting a user as both the author and a contributor, they show up twice in the entry.
|
To be merged after milestone/1.7
This pull request contains the ability to be able to change the author and add contributors to an entry. As this is a feature that may not be needed by everyone you can activate it by defining a global variable in your
wp-config.php:define('LIVEBLOG_ALLOW_AUTHOR_SELECT', true);When this feature is enabled the editor now has two drop downs below it allowing you to select and edit the authors and contributors. The author updates the actual author of the comment and the contributors are stored as comment meta as an array of ids.