Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: longer timeout for test send #389

Merged
merged 1 commit into from
Jan 5, 2021
Merged

fix: longer timeout for test send #389

merged 1 commit into from
Jan 5, 2021

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Dec 21, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Sending a test email often fails with no useful error message, although the email is sent anyway. This is most likely due to an API timeout. This branch simply increases the timeout for test sends to 60s, which is much higher than before.

Closes #140

How to test the changes in this Pull Request:

This one is difficult to test. Just try sending a bunch of test emails from a slow environment and verify there is always a success message.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-assigned this Dec 21, 2020
dkoo
dkoo approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tough to objectively confirm this, but on master I see the error message quite often, while on this branch I didn't see it after several tests (and the "loading" state when clicking the "Send a Test Email" button lasts much longer).

@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Jan 5, 2021
@jeffersonrabb jeffersonrabb merged commit 0d18659 into master Jan 5, 2021
@jeffersonrabb jeffersonrabb deleted the fix/test-send-timeouts branch January 5, 2021 03:14
matticbot pushed a commit that referenced this pull request Jan 12, 2021
@semantic-release-bot
chore(release): 1.16.2-alpha.1 [skip ci]
41e1769 
## [1.16.2-alpha.1](v1.16.1...v1.16.2-alpha.1) (2021-01-12)

### Bug Fixes

* alignment for elements using textAlign ([#390](#390)) ([405c33e](405c33e))
* longer timeout for test send ([#389](#389)) ([0d18659](0d18659))
* **mjml:** error handling ([f47fdf4](f47fdf4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.16.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 12, 2021
@semantic-release-bot
chore(release): 1.16.2 [skip ci]
75aa74e 
## [1.16.2](v1.16.1...v1.16.2) (2021-01-12)

### Bug Fixes

* alignment for elements using textAlign ([#390](#390)) ([405c33e](405c33e))
* longer timeout for test send ([#389](#389)) ([0d18659](0d18659))
* **mjml:** error handling ([f47fdf4](f47fdf4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.16.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

@adekbadek adekbadek Awaiting requested review from adekbadek

Assignees

@jeffersonrabb jeffersonrabb

Labels
released on @alpha released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic Mailchimp Error After Test Send
3 participants
@jeffersonrabb @matticbot @dkoo