Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Blockbase: Remove code block CSS #4562

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Blockbase: Remove code block CSS #4562

merged 1 commit into from
Sep 13, 2021

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

Since WordPress/gutenberg#31135 got merged, we can set the typeography for the code block in theme.json.

Monospace is the default for code elements in Chrome (and maybe other browsers) so maybe this is unnecessary, but it's probably better to be explicit?

@scruffian scruffian requested a review from a team September 9, 2021 09:44
@scruffian scruffian self-assigned this Sep 9, 2021
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The issue pointed out here doesn't really effect things for us.

@pbking pbking changed the base branch from trunk to develop September 13, 2021 20:41
@pbking pbking merged commit b3e07f0 into develop Sep 13, 2021
pbking pushed a commit that referenced this pull request Sep 13, 2021
@pbking pbking deleted the remove/code-block-css branch September 28, 2021 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants