Editor Media Google Photos: album / folder dropdown selector #25734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes parent media modal component responsible for handling selection of new Folder (made via dropdown). Detail of currently selected Folder is passed down prop chain and reflected in data query sent to API and also as part of props passed to component responsible for rendering list of Media # Conflicts: # client/my-sites/media-library/external-media-header.jsx
Enables the ability to disabled a SelectDropdown component by passing a disabled prop. This will cause the component to ignore all interactions and display with styles and aria attrs indicating it is disabled.
Previously the Dropdown would encounter problems when Media content was being loaded into the list of media. Disabling during fetching helps avoid this # Conflicts: # client/my-sites/media-library/style.scss
|
@johngodley
|
|
The last I looked the media library wasn't using redux, and so if you maintain folder state much like it is with search then the value can be passed to the request and passed along when a folder is chosen. And yep, making an initial request to populate the dropdown sounds like it will be necessary. I can't remember if albums are implemented in our API (or maybe they are untested), so we'll need to get that working too. They are present in Picasa so it shouldn't be a lot of work either way. |
|
Closing in favour of Direct PR from Automattic repo. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dropdown to the Google Photos Modal within the editor in response to
#22771
Allows user to select an existing folder from their Google Photos Library (currently the Picasa API) and filter the list of photos to show only photos from that Album. Also allows user to select to show All Photos.