Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Inbox): remove fee and deadline #4833

Closed
Tracked by #4492
LHerskind opened this issue Feb 28, 2024 · 0 comments · Fixed by #5206
Closed
Tracked by #4492

refactor(Inbox): remove fee and deadline #4833

LHerskind opened this issue Feb 28, 2024 · 0 comments · Fixed by #5206
Assignees
@benesjan

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Feb 28, 2024 •
edited
Loading

With the new model we don't need the deadline and fee values in the l1 to l2 messages. Get rid of them in the L1ToL2Message struct and portals. Likely quite coupled with contracts assignments in #4492.
@LHerskind LHerskind mentioned this issue Feb 28, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 28, 2024
@LHerskind LHerskind mentioned this issue Mar 5, 2024
Merged
@LHerskind LHerskind changed the title refactor: remove fee and deadline refactor(Inbox): remove fee and deadline Mar 8, 2024
@benesjan benesjan mentioned this issue Mar 17, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 18, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Mar 19, 2024
@benesjan @AztecBot
refactor: old inbox purge (#5206)
a9e19a2 
Fixes AztecProtocol/aztec-packages#5263
Fixes AztecProtocol/aztec-packages#4833
Fixes AztecProtocol/aztec-packages#5071
\+ did a few random improvements (e.g. not waiting 5 seconds for
archiver to have message available but polling for it instead)
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
@superstar0402
refactor: old inbox purge (#5206)
f1824d1 
Fixes AztecProtocol/aztec-packages#5263
Fixes AztecProtocol/aztec-packages#4833
Fixes AztecProtocol/aztec-packages#5071
\+ did a few random improvements (e.g. not waiting 5 seconds for
archiver to have message available but polling for it instead)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: old inbox purge AztecProtocol/aztec-packages
2 participants
@benesjan @LHerskind