refactor!: logs refactor

[iAmMichaelConnor]

Branched from #11400 - hence the gigantic-looking diff.
It's really just commit 65b7d1c onwards.

Supersedes #11400

For a NoteInterface, there's a to_be_bytes method, which doesn't just return a byte-conversion of the contents of the note; it also injects a note_type_id (which, ok, you might argue is acceptable) and also a storage_slot (which isn't really a part of the note struct). I removed the to_be_bytes method, which was only really being used by log computation code, and put byte conversion in the log computation code. If we eventually move to a "Note Container" approach, where a NoteContainer contains all of the metadata about a note, we might decide that a to_be_bytes method for that container could work.

I made a corresponding change for the EventInterface too, for consistency.

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://67954f987bdbe2ca2f6c7b0a--aztec-docs-dev.netlify.app

[github-actions]

Changes to public function bytecode sizes

Generated at commit: 2ff645dac120db12c62a9e9b6bc83606f7a81430, compared to commit: ab2c860c747d3051a1cb85ad6ce5fac2a68867f7

🧾 Summary (100% most significant diffs)

Program	Bytecode size in bytes (+/-)	%
Token::finalize_mint_to_private	+168 ❌	+3.43%
Token::_finalize_mint_to_private_unsafe	+168 ❌	+3.40%
Token::finalize_transfer_to_private	+168 ❌	+3.20%
Token::_finalize_transfer_to_private_unsafe	+168 ❌	+3.17%
Token::complete_refund	+168 ❌	+2.91%
NFT::finalize_transfer_to_private	+118 ❌	+2.65%
NFT::_finalize_transfer_to_private_unsafe	+118 ❌	+2.62%
Token::public_dispatch	+168 ❌	+0.54%
NFT::public_dispatch	+118 ❌	+0.52%

---

Full diff report 👇

Program	Bytecode size in bytes (+/-)	%
Token::finalize_mint_to_private	5,063 (+168)	+3.43%
Token::_finalize_mint_to_private_unsafe	5,110 (+168)	+3.40%
Token::finalize_transfer_to_private	5,415 (+168)	+3.20%
Token::_finalize_transfer_to_private_unsafe	5,462 (+168)	+3.17%
Token::complete_refund	5,939 (+168)	+2.91%
NFT::finalize_transfer_to_private	4,569 (+118)	+2.65%
NFT::_finalize_transfer_to_private_unsafe	4,616 (+118)	+2.62%
Token::public_dispatch	31,313 (+168)	+0.54%
NFT::public_dispatch	22,850 (+118)	+0.52%

[nventuro]

Have some comments, but I'd rather leave for those for future PRs and get this in, since we do need these critical improvements. bytes.nr in particular could use some love, but I do understand that it currently simply exists an appendage of this PR.

[nventuro]

Suggested change

	/// Converts a base field element to scalar field element.
	/// This is fine because modulus of the base field is smaller than the modulus of the scalar field.
	fn fr_to_fq(r: Field) -> Scalar {
	/// Converts a base field element to scalar field element.
	/// This is lossless because the modulus of the base field is smaller than the modulus of the scalar field.
	fn fr_to_fq(r: Field) -> Scalar {

[nventuro]

Did this exist before this PR?

[iAmMichaelConnor]

Yep, it sure did! It was one of the reasons I delved into the bytes.nr file and began refactoring it.

[iAmMichaelConnor]

I didn't go as far as plumbing this function into the log computation yet.

[nventuro]

?!

[iAmMichaelConnor]

Yeah, this is bad. The good news is, it was like this in Noir's ec lib, so it's not my fault. The bad news is: it is my fault that I copied it here.

[nventuro]

smort