chore: add support for caching node_modules within a nested repository
#12862
+31
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
tf/remove-hack
branch
from
c2f954e to
dde2504
Compare
TomAFrench
changed the title
TomAFrench
changed the title
node_modules within a nested repository
charlielye
reviewed
Mar 19, 2025
TomAFrench
commented
Mar 19, 2025
charlielye
requested changes
Mar 20, 2025
charlielye
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a hack added in #12760
This fixes an issue where we were querying the root git repository for hashes for files which are only tracked in the
noir/noir-reporepository. We now set theREPO_PATHenv variable so that we rungit ls-treeon the correct repository.