Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(circuits): Base rollup cbind msgpack #2263

Merged
merged 8 commits into from
Sep 14, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
2096 - remove dead code from base rollup cbind
jeanmon committed Sep 14, 2023
commit 0fe761bdae105d6e1456333194824195c34adb7e
13 changes: 0 additions & 13 deletions circuits/cpp/src/aztec3/circuits/rollup/base/.test.cpp
Original file line number Diff line number Diff line change
@@ -70,17 +70,6 @@ class base_rollup_tests : public ::testing::Test {
bool assert_no_circuit_failure = true)
{
info("Retesting via cbinds....");
// TODO(banks12) might be able to get rid of proving key buffer
uint8_t const* pk_buf = nullptr;
size_t const pk_size = base_rollup__init_proving_key(&pk_buf);
(void)pk_size;
// info("Proving key size: ", pk_size);

// TODO(banks12) might be able to get rid of verification key buffer
uint8_t const* vk_buf = nullptr;
size_t const vk_size = base_rollup__init_verification_key(pk_buf, &vk_buf);
(void)vk_size;
// info("Verification key size: ", vk_size);

std::vector<uint8_t> base_rollup_inputs_vec;
serialize::write(base_rollup_inputs_vec, base_rollup_inputs);
@@ -119,8 +108,6 @@ class base_rollup_tests : public ::testing::Test {
}
}

free((void*)pk_buf);
free((void*)vk_buf);
// free((void*)proof_data);
free((void*)public_inputs_buf);
// info("finished retesting via cbinds...");
24 changes: 0 additions & 24 deletions circuits/cpp/src/aztec3/circuits/rollup/base/c_bind.cpp
Original file line number Diff line number Diff line change
@@ -23,30 +23,6 @@ using aztec3::circuits::rollup::native_base_rollup::base_rollup_circuit;
// WASM Cbinds
extern "C" {

WASM_EXPORT size_t base_rollup__init_proving_key(uint8_t const** pk_buf)
{
std::vector<uint8_t> pk_vec(42, 0);

auto* raw_buf = (uint8_t*)malloc(pk_vec.size());
memcpy(raw_buf, (void*)pk_vec.data(), pk_vec.size());
*pk_buf = raw_buf;

return pk_vec.size();
}

WASM_EXPORT size_t base_rollup__init_verification_key(uint8_t const* pk_buf, uint8_t const** vk_buf)
{
std::vector<uint8_t> vk_vec(42, 0);
// TODO remove when proving key is used
(void)pk_buf; // unused

auto* raw_buf = (uint8_t*)malloc(vk_vec.size());
memcpy(raw_buf, (void*)vk_vec.data(), vk_vec.size());
*vk_buf = raw_buf;

return vk_vec.size();
}

WASM_EXPORT uint8_t* base_rollup__sim(uint8_t const* base_rollup_inputs_buf,
size_t* base_rollup_public_inputs_size_out,
uint8_t const** base_or_merge_rollup_public_inputs_buf)
4 changes: 0 additions & 4 deletions circuits/cpp/src/aztec3/circuits/rollup/base/c_bind.h
Original file line number Diff line number Diff line change
@@ -7,11 +7,7 @@

extern "C" {

WASM_EXPORT size_t base_rollup__init_proving_key(uint8_t const** pk_buf);
WASM_EXPORT size_t base_rollup__init_verification_key(uint8_t const* pk_buf, uint8_t const** vk_buf);
WASM_EXPORT size_t base_rollup__dummy_previous_rollup(uint8_t const** previous_rollup_buf);
WASM_EXPORT uint8_t* base_rollup__sim(uint8_t const* base_rollup_inputs_buf,
size_t* base_rollup_public_inputs_size_out,
uint8_t const** base_or_merge_rollup_public_inputs_buf);
WASM_EXPORT size_t base_rollup__verify_proof(uint8_t const* vk_buf, uint8_t const* proof, uint32_t length);
}