Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ProverPolynomials owning data #3292

Closed
wants to merge 94 commits into from

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Nov 12, 2023

@ludamad ludamad force-pushed the ad/prover-polynomials-own-data branch from 1b18d63 to b5e15dc Compare November 12, 2023 09:47
@@ -140,6 +140,18 @@
"LDFLAGS": "-fsanitize=thread"
}
},
{
"name": "ftime-trace",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation benchmarking preset

@ludamad ludamad force-pushed the ad/prover-polynomials-own-data branch from b5e15dc to 606226d Compare November 12, 2023 09:59
@ludamad ludamad marked this pull request as draft November 12, 2023 10:05
@ludamad
Copy link
Collaborator Author

ludamad commented Nov 12, 2023

Looking at tests

@AztecBot
Copy link
Collaborator

AztecBot commented Nov 12, 2023

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (8): 15.7 (-84%)
  • note_trial_decrypting_time_in_ms (32): 23.5 (-74%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f1095124 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,852 868,088 3,449,432
l1_rollup_execution_gas 841,939 3,595,196 22,204,801
l2_block_processing_time_in_ms 2,060 (+4%) 7,611 30,166
note_successful_decrypting_time_in_ms 304 (+3%) 914 (+4%) 3,322 (+4%)
note_trial_decrypting_time_in_ms ⚠️ 15.7 (-84%) ⚠️ 23.5 (-74%) 133 (-1%)
l2_block_building_time_in_ms 13,463 (+1%) 52,979 (+1%) 211,471
l2_block_rollup_simulation_time_in_ms 12,075 (+1%) 47,489 189,811
l2_block_public_tx_process_time_in_ms 1,342 (+2%) 5,352 (+2%) 21,165 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 21,549 (-3%) 42,260 (-1%)
note_history_successful_decrypting_time_in_ms 2,024 (-3%) 3,985 (-2%)
note_history_trial_decrypting_time_in_ms 121 145
node_database_size_in_bytes 1,626,918 1,096,033
pxe_database_size_in_bytes 29,748 59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 776 (+2%) 61,697 18,905
private-kernel-ordering 129 (+3%) 24,297 8,153
base-rollup 1,765 656,311 814
root-rollup 174 (+4%) 4,072 1,097
private-kernel-inner 802 (+2%) 81,568 18,905
public-kernel-private-input 41.1 (-1%) 41,519 18,841
public-kernel-non-first-iteration 25.8 (-1%) 41,497 18,841
merge-rollup 16.1 (+7%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,787 27,547

Base automatically changed from ad/chore/flavor-refactor-part2 to master November 13, 2023 13:15
@ludamad
Copy link
Collaborator Author

ludamad commented Dec 13, 2023

Superseded by #3560

@ludamad ludamad closed this Dec 13, 2023
@ludamad ludamad deleted the ad/prover-polynomials-own-data branch August 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ownership of polynomials in flavor classes
3 participants