Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build protocol circuits on CI and stop committing artifacts #3816

Merged
merged 21 commits into from
Jan 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
035a8a6
add contract compilation and typescript generation to yarn build
dan-aztec Jan 3, 2024
243a77e
Merge branch 'master' into dan/build-protocol-artifacts-on-ci
dan-aztec Jan 3, 2024
1d2e663
also generate types on bootstrap
dan-aztec Jan 3, 2024
f2913c2
also do tsc -b to generate JS files
dan-aztec Jan 4, 2024
144af27
update point to grumpkin point
dan-aztec Jan 4, 2024
4fa2c29
update dockerfile to match bootstrap.sh change
dan-aztec Jan 4, 2024
6ab13de
make directory in noir:types
dan-aztec Jan 4, 2024
b0d20d1
move mkdir to ts script, not sure why merkle tree dep issue though
dan-aztec Jan 4, 2024
935c50f
try without formatting:fix
dan-aztec Jan 4, 2024
f449ccf
just format src/types
dan-aztec Jan 4, 2024
b88e2d1
format inside the typescript generator
dan-aztec Jan 4, 2024
4296afa
pr feedback
dan-aztec Jan 4, 2024
ba0bec7
Merge branch 'master' into dan/build-protocol-artifacts-on-ci
dan-aztec Jan 4, 2024
1548a57
move formatting out of typescript back into yarn command
dan-aztec Jan 4, 2024
0ca1a37
Merge branch 'dan/build-protocol-artifacts-on-ci' of https://github.c…
dan-aztec Jan 4, 2024
9d79c0c
unused import
dan-aztec Jan 4, 2024
6372bcb
commit deletion
dan-aztec Jan 4, 2024
cdc1089
hmm didnt actually delete the files on last merge conflict
dan-aztec Jan 5, 2024
fb1cb49
Merge branch 'master' into dan/build-protocol-artifacts-on-ci
dan-aztec Jan 5, 2024
caa0d39
Merge branch 'master' into dan/build-protocol-artifacts-on-ci
dan-aztec Jan 5, 2024
379a995
Merge branch 'master' into dan/build-protocol-artifacts-on-ci
dan-aztec Jan 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
also do tsc -b to generate JS files
dan-aztec committed Jan 4, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit f2913c2c24a21af5b80bba0a335e69a0c2021f35
2 changes: 1 addition & 1 deletion yarn-project/noir-protocol-circuits/package.json
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
"scripts": {
"build": "yarn clean && tsc -b",
"build:dev": "tsc -b --watch",
"build:noir": "yarn noir:build && yarn noir:types",
"build:noir": "yarn noir:build && yarn noir:types && tsc -b",
"clean": "rm -rf ./dest .tsbuildinfo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean needs to be updated and included in build:noir (build).

"formatting": "run -T prettier --check ./src && run -T eslint ./src",
"formatting:fix": "NODE_OPTIONS='--max-old-space-size=8096' run -T eslint --fix ./src && run -T prettier -w ./src",