Skip to content
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

[EPH] use EventHubConnectionConfig and remove dependency on amp-common and rhea-promise #166

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

amarzavery
Copy link
Collaborator

@amarzavery amarzavery commented Oct 5, 2018

  • Remove @azure/amqp-common and rhea-promise as dependencies, since we use very little from
    those libraries and there is a risk of having two instances of rhea in the dependency chain which
    can cause problems while encoding types for filters.
  • HostContext.connectionConfig is now of type EventHubConnectionConfig.
  • Minimum dependency on @azure/event-hubs: "^1.0.6".

@amarzavery amarzavery force-pushed the component branch 4 times, most recently from 43c7108 to 6198ab8 Compare October 5, 2018 20:03
@amarzavery
Copy link
Collaborator Author

✅ Validation status: passed

File Status Preview URL Details
.travis.yml ✅Succeeded
processor/changelog.md ✅Succeeded
processor/lib/azureBlob.ts ✅Succeeded
processor/lib/blobService.ts ✅Succeeded
processor/lib/hostContext.ts ✅Succeeded
processor/lib/partitionScanner.ts ✅Succeeded
processor/lib/util/constants.ts ✅Succeeded
processor/lib/util/utils.ts ✅Succeeded
processor/package-lock.json ✅Succeeded
processor/package.json ✅Succeeded
processor/tests/eph.spec.ts ✅Succeeded
processor/tests/iothub.spec.ts ✅Succeeded
processor/tests/retry.spec.ts ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@amarzavery amarzavery merged commit dff1079 into Azure:master Oct 5, 2018
@amarzavery
Copy link
Collaborator Author

✅ Validation status: passed

File Status Preview URL Details
.travis.yml ✅Succeeded
processor/changelog.md ✅Succeeded
processor/lib/azureBlob.ts ✅Succeeded
processor/lib/blobService.ts ✅Succeeded
processor/lib/hostContext.ts ✅Succeeded
processor/lib/partitionScanner.ts ✅Succeeded
processor/lib/util/constants.ts ✅Succeeded
processor/lib/util/utils.ts ✅Succeeded
processor/package-lock.json ✅Succeeded
processor/package.json ✅Succeeded
processor/tests/eph.spec.ts ✅Succeeded
processor/tests/iothub.spec.ts ✅Succeeded
processor/tests/retry.spec.ts ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant