POC - Refactor .NET 8 detection to eliminate FUNCTIONS_INPROC_NET8_ENABLED DLL approach #4249
+61
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed IsInProcDotNet8Enabled from StartHostAction.cs and updated methods to use DotnetHelpers.IsDotNet8() for .NET 8 detection. Added IsDotNet8 and GetTargetFramework methods to DotnetHelpers.cs for framework inspection. Introduced GetScriptFilePath in ExtensionsHelper.cs to extract script file paths from function.json. Updated ValidateHostRuntimeAsync_MatchesExpectedResults test to pass boolean directly.
|
Hi - the setting is a by-design requirement. It's use for local development intentionally mirrors the requirement in the hosting platform. Some publishing tools will rely upon this to get hosted configuration right, and it reinforces the requirement for users in general. We do not intend to remove this. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update target framework detection and add new method
Refactor the way .NET 8 projects are detected by removing the IsInProcDotNet8Enabled method and introducing DotnetHelpers.IsDotNet8.
The
IsDotNet8method uses the main DLL file to determine the target framework. Additionally, a new methodGetScriptFilePathhas been added toExtensionsHelper.csto retrieve the script file path, but it is currently incomplete and requires further implementation.Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist