Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warmup URL in placeholder simulation mode. #10912

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Mar 7, 2025

Host was not executing the warmup middleware in the cold start pipeline runs. When running in placeholder simulation mode, warmup will be executed on the call to homepage. This fix will resolve that issue.

Here is a successful run with this fix. Logs confirm warmup is being executed.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested a review from a team as a code owner March 7, 2025 00:19
@kshyju kshyju merged commit 5f7ac2f into dev Mar 7, 2025
9 checks passed
@kshyju kshyju deleted the shkr/fix_warmup_url branch March 7, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants