Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for faas.invoke_duration metric #10929

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Conversation

RohitRanjanMS
Copy link
Member

@RohitRanjanMS RohitRanjanMS commented Mar 17, 2025

  • Adding support for faas.invoke_duration metric.
  • Updating attributes as per updated spec.
  • Removed faas.version as it's no longer applicable.
  • Setting http.route and display name.
image

resolves #10454

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@RohitRanjanMS RohitRanjanMS marked this pull request as ready for review March 17, 2025 10:05
@RohitRanjanMS RohitRanjanMS requested a review from a team as a code owner March 17, 2025 10:05
@RohitRanjanMS RohitRanjanMS requested a review from kshyju March 17, 2025 18:08
@RohitRanjanMS RohitRanjanMS merged commit d1e06f1 into dev Mar 17, 2025
9 checks passed
@RohitRanjanMS RohitRanjanMS deleted the roranjan/metrics branch March 17, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenTelemetry] - Metrics
4 participants