V2 Encryption Bug 4MB file downloads (#41813) #42213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* testing, need to get this branch on my other workstation * adding broken test * updating tests * tests with logging * updating test and adding fix * making test paramaterized and adding change for only encryption v2 downloads * fixing imports * wip context addition * context implementation and sync / async tests * adding back unpulled tests * consolidating one of the async util methods * addressing all comments besides 1 * removing leftover changes and adding back test for V2 * kyle test * adjusting unencrypted blob length calculation * recording tests and fixing style * addressing comments * changelog update * fixing messed up recorded test * adding more test cases and updating adjustment method signature * adding missed recordings and fixing style * changing offsetAdjustment to a long to prevent int overflow, and added support for unencrypted blob length for blobinputstream * adding test for integer overflow, removing redundant test, adding helper method to blobinputstream * adjusting changelong * removing unused imports * changing blobinputstream util method to use long instead of Long
srnagar
requested review from
ibrahimrabab,
seanmcc-msft,
ibrandes,
kyleknap and
alzimmermsft
as code owners
ibrandes
approved these changes
Oct 8, 2024
|
/azp run java - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
/azp run java - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ibrandes
merged commit 5e81fa0
into
Azure:release/patch/storage-common-12270
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing, need to get this branch on my other workstation
adding broken test
updating tests
tests with logging
updating test and adding fix
making test paramaterized and adding change for only encryption v2 downloads
fixing imports
wip context addition
context implementation and sync / async tests
adding back unpulled tests
consolidating one of the async util methods
addressing all comments besides 1
removing leftover changes and adding back test for V2
kyle test
adjusting unencrypted blob length calculation
recording tests and fixing style
addressing comments
changelog update
fixing messed up recorded test
adding more test cases and updating adjustment method signature
adding missed recordings and fixing style
changing offsetAdjustment to a long to prevent int overflow, and added support for unencrypted blob length for blobinputstream
adding test for integer overflow, removing redundant test, adding helper method to blobinputstream
adjusting changelong
removing unused imports
changing blobinputstream util method to use long instead of Long
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines