Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown fix for: Conditionally declare a property value #1194

Merged
merged 3 commits into from
Dec 19, 2020

Conversation

ctaggart
Copy link
Contributor

I'm learning bicep, so I'm reading docs and going through examples. It looks like VS Code and GitHub disagree on escaping pipes in tables. This fixes it to work in GitHub.

@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #1194 (d350921) into main (bacb1a9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   94.49%   94.49%   -0.01%     
==========================================
  Files         336      336              
  Lines       16813    16825      +12     
  Branches       14       14              
==========================================
+ Hits        15888    15898      +10     
- Misses        925      927       +2     
Flag Coverage Δ
dotnet 95.03% <ø> (-0.01%) ⬇️
typescript 27.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Decompiler/TemplateConverter.cs 85.90% <0.00%> (-0.26%) ⬇️
src/Bicep.Core/TypeSystem/TypeAssignmentVisitor.cs 96.78% <0.00%> (+0.13%) ⬆️

@alex-frankel
Copy link
Collaborator

Good catch, but this is actually the wrong ternary syntax (also my fault!). It should be:

isMonday ? 'valueIfTrue' : 'valueIfFalse'

Want to make this change for us?

@ctaggart ctaggart changed the title markdown fix, escape pipe in GitHub table markdown fix for: Conditionally declare a property value Dec 19, 2020
@ctaggart
Copy link
Contributor Author

done ✅

@alex-frankel alex-frankel merged commit a514ee9 into Azure:main Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants