Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-bicep hygiene #14590

Merged
merged 10 commits into from
Jul 19, 2024
Merged

vscode-bicep hygiene #14590

merged 10 commits into from
Jul 19, 2024

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Jul 19, 2024

Once #14584 is merged we should consider merging vscode-bicep-ui and vscode-bicep and configure it with npm workspaces. The PR cleans up the vscode-bicep project to make sure we have consistent linter rules and formatter settings to make it easier to merge the folders.

Changes:

  • Consolidated TypeScript config files.
  • Updated ESLint rules.
    • Made rules less strict overall.
    • Removed the annoying Prettier formatting related rules.
    • No more yellow or red squiggly line related to formatting violations.
    • Cleaned up all stale linter rule disabling comments.
  • Updated prettier configuration
    • Changed printWidth from 80 to 120 since we all have modern high-resolution and ultra-wide monitors :p
    • Added a plugin for automatically sorting imports.
    • Formatted all code under vscode-bicep, which accounts for 99% of the file changes.
  • Fixed a critical Webpack bundling circular dependency warning.
  • Added CI steps for formatting the vscode-bicep folder.

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Test this change out locally with the following install scripts (Action run 10012063346)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10012063346
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10012063346"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10012063346
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10012063346"

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Dotnet Test Results

    72 files   -     35      72 suites   - 35   23m 16s ⏱️ - 10m 22s
10 968 tests  -     18  10 968 ✅  -     18  0 💤 ±0  0 ❌ ±0 
25 816 runs   - 12 898  25 816 ✅  - 12 898  0 💤 ±0  0 ❌ ±0 

Results for commit c5d55ec. ± Comparison against base commit 57a44c0.

♻️ This comment has been updated with latest results.

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@StephenWeatherford StephenWeatherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shenglol shenglol enabled auto-merge (squash) July 19, 2024 17:25
@shenglol shenglol merged commit 5d3615c into main Jul 19, 2024
44 checks passed
@shenglol shenglol deleted the shenglol/vscode-bicep-hygiene branch July 19, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants