Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes deny subnet without nsg & udr policy #249

Closed
wants to merge 8 commits into from
Closed

Conversation

withstu
Copy link
Contributor

@withstu withstu commented Jan 6, 2022

Overview/Summary

This PR fixes the issue that is described here: Azure/Enterprise-Scale#407
Despite of the deny policies Deny-Subnet-Without-Udr & Deny-Subnet-Without-Nsg a vNet with a subnet without udr or nsg can be created in a single ARM deployment. After the deployment the subnets get be marked as non-compliant.

Cross-Reference: Azure/Enterprise-Scale#885

This PR fixes/adds/changes/removes

  1. Deny-Subnet-Without-Nsg will allow a network with a subnet to be created. Enterprise-Scale#407

Breaking Changes

Testing Evidence

After the fix I now getting a deny, when I try to create a vnet with a subnet without udr & nsg.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@jschul711
Copy link

+1

@jtracey93
Copy link
Collaborator

Closing as commented here on the ESLZ PR created Azure/Enterprise-Scale#885 (comment)

@jtracey93 jtracey93 closed this Jan 6, 2022
@jtracey93 jtracey93 added duplicate This issue or pull request already exists Resolution: Duplicate labels Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists Resolution: Duplicate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants