Full replacement of VSCodeDropdown & VSCodeOption with custom react elements [Webview-UI-toolkit deprecation] #1276
+550
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejhan
added
enhancement 🚀
tejhan
changed the title
tejhan
requested review from
Tatsinnit,
ReinierCC,
hsubramanianaks and
qpetraroia
Signed-off-by: Tejhan Diallo <82427254+tejhan@users.noreply.github.com>
ReinierCC
previously approved these changes
Mar 10, 2025
Signed-off-by: Tejhan Diallo <82427254+tejhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note : This PR builds on top of PR's #1259 - 1261, so this can be slated for merge/review after the preceding PR's are merged.
This should be the second to last PR, & once approved we can slate the final PR for removal of the entire package & leftover elements
This PR fully removes the VSCodeDropdown & VSCodeOption elements, & replaces them with CustomDropdown & CustomDropdownOption, 2 new elements that can be imported and used as a react component in any of our panels. The elements are styled with respect to vscode's display & coloring settings.
These elements have no external dependencies which will allow us to use fully functional vscode themed dropdowns in any of our commands without needing to import any toolkits. (Also allows further customization of our own in future)
For future reference, < CustomDropdownOption > can be used as a single tag, with the label attribute serving as the label. Other attributes like onchange, disabled, etc are also functional with these new elements. < CustomDropdown > works almost identically to the replaced VSCodeDropdown, where the values & selected elements are controlled with state variables & onchange functions.
Commands affected:
Dependent Components altered:
For anyone testing, you can utilize the inputs in each of the effected commands to ensure submission of data is correct & the ability to scroll through options, search in dropdown, etc. are all working as intended.
.vsix for testing: vscode-aks-tools-1.6.0-dep5-2.vsix.zip