TCP Dump Bug Fix #1291
Merged
TCP Dump Bug Fix #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR fixes a bug where the TCP dump download button remains disabled if a user cancels the file selection.
- Adds a check for missing file selection.
- Sends an error response to reset the download state.
Reviewed Changes
| File | Description |
|---|---|
| src/panels/TcpDumpPanel.ts | Added error handling to reset the download state when no file is chosen. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/panels/TcpDumpPanel.ts:422
- [nitpick] Ensure consistency in error messaging style across the application. If similar error responses elsewhere follow a different format, consider aligning this message accordingly.
// Reset download state with error message if no file path was selected
tejhan
requested review from
ReinierCC,
hsubramanianaks,
qpetraroia and
bosesuneha
Tatsinnit
approved these changes
Mar 4, 2025
ReinierCC
approved these changes
Mar 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight bug observed where if a user escapes the file selection menu after clicking the button to download a TCP dump capture, the button stays stuck in the disabled downloading state.
This PR adds an error response to correct for that.
(To reproduce, select Troubleshoot Network Health > Collect TCP Dumps, select a node, start & stop a capture, then click the download button that appears next to completed capture item)
.vsix: vscode-aks-tools-1.6.1-tcpfix.vsix.zip