added default project value disable_account_creation_rpc #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
? this should not be the default value. |
What value should be the default? |
|
Disable account create should by default probably be set to true. |
Changed default value of config.disable_account_creation_rpc from 0 to 1
|
The account creation RPC needs to be enabled for the integration tests. |
|
It depends how early in the configuration process you want members of the public to start joining your test team - which in turn depends on whether you are testing integration on a public or private IP or url. I think most projects do test in public, but with account creation requiring an invitation code: the two defaults should be considered in tandem. |
|
The php unit tests use this RPC to create a test account so the Travis integration tests fail if this is not enabled. |
lfield
added a commit
that referenced
this pull request
Nov 14, 2018
added default project value disable_account_creation_rpc (cherry picked from commit 9942a6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing GDPR compliance I have noticed that in
project/config.xmlthe attributedisable_account_creation_rpcwas missing