Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle contacts limited permission #1446

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Handle contacts limited permission #1446

merged 6 commits into from
Feb 20, 2025

Conversation

mvanbeusekom
Copy link
Member

The package wasn't currently handling the new CNAuthorizationStatusLimited introduce in ios18. Older versions of ios will remain unchanged. Here's a screen recording showcasing the change

  • ios 17.2
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-10.at.13.43.12.mp4
  • ios 18.0
Simulator.Screen.Recording.-.Logged.In.16.Pro.-.2024-10-10.at.13.46.09.mp4

List at least one fixed issue.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

Sorry, something went wrong.

Hari-07 and others added 5 commits February 20, 2025 10:18

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
* Handle contacts limited permission

* Version bump and comments
@Hari-07
Copy link
Contributor

Hari-07 commented Feb 20, 2025

You could've left the changes you wanted/needed on the original PR instead of just taking it up

@mvanbeusekom
Copy link
Member Author

mvanbeusekom commented Feb 20, 2025

You could've left the changes you wanted/needed on the original PR instead of just taking it up

True, but the thing is that I am immediately debugging the build environment and upgrading to latest Flutter and that is hard to leave to the community. I do appreciate the incentive though.

Also I feel this is not really your problem, but it is on us for not keeping the plugin up to date.

@mvanbeusekom mvanbeusekom merged commit 78bd670 into main Feb 20, 2025
1 of 2 checks passed
@mvanbeusekom mvanbeusekom deleted the issue/1387 branch February 20, 2025 13:24
@mvanbeusekom
Copy link
Member Author

I have just published version 9.4.6 of the permission_handler_apple package to pub.dev and you should be able to update your project by running flutter pub upgrade permission_handler_apple.

However I am now going through the other platforms as well and updating to the latest Flutter specs, so if you run into problems, let me know and updates for the other packages should be rolling out in a few hours.

@Pszione
Copy link

Pszione commented Feb 20, 2025

I just updated to 9.4.6 and it's working great! Thanks @mvanbeusekom
Question: when limited, can I open the system modal for the user to select more contacts?

@mvanbeusekom
Copy link
Member Author

Question: when limited, can I open the system modal for the user to select more contacts?

Not sure about that, you could try to ask for permission again (haven't tried that).

However most likely you'll have to redirect the user to the iOS "Settings" (which can be opened through the openAppSettings() method).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants