Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Settings out of Common.h #294

Closed
3 tasks done
jimkoen opened this issue Feb 18, 2024 · 1 comment
Closed
3 tasks done

Refactor Settings out of Common.h #294

jimkoen opened this issue Feb 18, 2024 · 1 comment
Assignees

Comments

@jimkoen
Copy link
Contributor

jimkoen commented Feb 18, 2024

Currently, dealing with TSettings in Common.h is very tedious (for example when wanting to output all settings for flush them, as requested in #158 ). In addition, Settings access is currently not threadsafe, and encapsulation of security related settings (i.e. AuthKey) from the rest of the application is implemented in a crude manner.

Settings need to be refactored into an abstraction that least supports:

  • Thread safe access
  • Some form of rudimentary support / foresight in implementation to be able to handle them from within the Lua interpreter
  • Masking individual settings from parts of the application for security reasons
@jimkoen jimkoen self-assigned this Feb 18, 2024
@lionkor lionkor moved this to In progress in Development Feb 26, 2024
@jimkoen
Copy link
Contributor Author

jimkoen commented Jun 26, 2024

Closed, was fixed in #295

@jimkoen jimkoen closed this as completed Jun 26, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant