Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Running settings help returns nothing #158

Closed
Mack29446 opened this issue Nov 22, 2022 · 3 comments · Fixed by #295
Closed

[Bug] Running settings help returns nothing #158

Mack29446 opened this issue Nov 22, 2022 · 3 comments · Fixed by #295
Assignees
Labels
bug Something isn't working

Comments

@Mack29446
Copy link
Contributor

Fill out general information
OS: Linux
BeamMP-Server Version: 3.1.1

Describe the bug
Running the settings help command, as suggested within the help command, returns nothing

To Reproduce
Steps to reproduce the behavior:

  1. Run settings help
  2. Observe nothing happen

Expected behavior
Something to happen

@Mack29446 Mack29446 added the bug Something isn't working label Nov 22, 2022
@lionkor
Copy link
Contributor

lionkor commented Nov 23, 2022

Yeah, I'm an idiot and forgot to remove settings from 3.1.x. It'll be implemented properly in 3.2.0, and has get, set, etc.

Please feel free to try it (contact me to get a pre-release-build for example), or see an example here:
image

So this will be fixed by v3.2.0, and can't be fixed in v3.1.1 (as it doesn't exist).

@lionkor lionkor moved this to Backlog in Development Dec 10, 2023
@jimkoen jimkoen self-assigned this Jan 16, 2024
@jimkoen jimkoen moved this from Backlog to Planned in Development Jan 25, 2024
@jimkoen
Copy link
Contributor

jimkoen commented Feb 17, 2024

Should this maybe go alongside refactoring settings all together? The behavior from the screenshot is proving hard to implement without some ugly code like a massive if/else if/else if etc statement.

If so, I would go ahead and open a separate issue for that.

@lionkor
Copy link
Contributor

lionkor commented Feb 17, 2024

Feel free to refactor the settings, but be aware they are used quite literally everywhere. Of course some settings shouldn't be accessible, only AuthKey comes to mind.

The TOML has to stay etc. and the behavior from the users side should be very similar. Make a new issue for sure!

@lionkor lionkor moved this from Planned to In progress in Development Feb 26, 2024
@jimkoen jimkoen linked a pull request Feb 26, 2024 that will close this issue
lionkor added a commit that referenced this issue Jun 26, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants