Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hard disconnect instead of ClientKick in timeout #320

Merged
merged 2 commits into from
May 11, 2024
Merged

Use hard disconnect instead of ClientKick in timeout #320

merged 2 commits into from
May 11, 2024

Conversation

lionkor
Copy link
Contributor

@lionkor lionkor commented May 11, 2024

No description provided.

OfficialLambdax
OfficialLambdax approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@OfficialLambdax OfficialLambdax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the case that this is supposed to troubleshoot. Works in that regard in all test case. A lua hangup may still appear, but the server is able to deal with it in time and resume the hungup state

@lionkor lionkor merged commit 5f9726f into minor May 11, 2024
9 checks passed
@lionkor lionkor deleted the timeout-kick-fix branch May 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfficialLambdax OfficialLambdax OfficialLambdax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionkor @OfficialLambdax