Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters in signal calls #139

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add missing parameters in signal calls #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/gaea/renderers/2D/gaea_renderer_2d.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func _draw_area(area: Rect2i) -> void:
## Draws the chunk at [param chunk_position].
func _draw_chunk(chunk_position: Vector2i) -> void:
_draw_area(Rect2i(chunk_position * generator.chunk_size, generator.chunk_size))
chunk_rendered.emit()
chunk_rendered.emit(chunk_position)


## Draws the whole grid.
Expand Down
2 changes: 1 addition & 1 deletion addons/gaea/renderers/2D/tilemap_gaea_renderer.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func _draw_area(area: Rect2i) -> void:
tile_info.terrain_set, tile_info.terrain
)

(func(): area_rendered.emit()).call_deferred()
(func(): area_rendered.emit(area)).call_deferred()


func _draw() -> void:
Expand Down
2 changes: 1 addition & 1 deletion addons/gaea/renderers/3D/gridmap_gaea_renderer.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func _draw_area(area: AABB) -> void:

grid_map.call_thread_safe("set_cell_item", cell, tile_info.index) # thread_safe paces these calls out when threaded.

(func(): area_rendered.emit()).call_deferred()
(func(): area_rendered.emit(area)).call_deferred()


func _draw() -> void:
Expand Down
2 changes: 1 addition & 1 deletion script_templates/GaeaRenderer2D/default.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ extends GaeaRenderer2D
func _draw_area(area: Rect2i) -> void:
# Write rendering code here.

area_rendered.emit()
area_rendered.emit(area)
2 changes: 1 addition & 1 deletion script_templates/GaeaRenderer3D/default.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ extends GaeaRenderer3D
func _draw_area(area: AABB) -> void:
# Write rendering code here.

area_rendered.emit()
area_rendered.emit(area)