-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boards: Added support for Lilygo-T-Display S3 #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added platformio configuration ttgo-t-display-S3-usb * added dependency to patched TFT_eSPI library on my github account - needed changes are not yet in master repo - upstream Xinyuan-LilyGO /T-Display-S3 has no tags * set TFT layout parameters from platfrom.ini * added ESP32-S3 support (differen reset reason enum)
BlueAndi
reviewed
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix or at least comment the findings. Thx.
BlueAndi
reviewed
Nov 30, 2022
BlueAndi
reviewed
Nov 30, 2022
* Enabled PSRAM memory (+8MB usable RAM) - This setting is crucial: board_build.arduino.memory_type = qio_opi * Use 16MB flash partition scheme - A custom one with 16MB-1Byte size is used to workaround a tool bug when trying to upload full 16MB see espressif/esptool#795 (comment) - Add PSRAM to info web page
* Added platform to README * Ignore all pin actions on not connected pins * Renamed brightness back to default_brightness * Avoid #ifdef for ESP variant specific includes * I2C pins changed to match demo code from Lilygo
BlueAndi
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added platformio configuration ttgo-t-display-S3-usb
added dependency to patched TFT_eSPI library on my github account
set TFT layout parameters from platfrom.ini
added ESP32-S3 support (differen reset reason enum)