This repository was archived by the owner on Nov 30, 2018. It is now read-only.
Don't use regex to split query string since this doesn't work correctly in IE8 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| value = parts[1] && decodeURIComponent(parts[1].replace(/\+/g, ' ')); | ||
| var sp = pair.indexOf("="), | ||
| key = sp === -1 ? pair : pair.substr(0, sp), | ||
| value = sp === -1 ? null : decodeURIComponent(pair.substr(sp + 1).replace(/\+/g, ' ')); |
There was a problem hiding this comment.
Just a heads up, might not be a problem. This makes ?foo= be
foo: ''
and ?foo
foo: null
Before both of these became
foo: undefined
Could have some unwanted effects, not sure though. Depends how that data is handled further.
I used this in a local patch I made.
var parts = pair.split('='),
key = parts.shift(),
rest = parts.join('=') || undefined
value = rest && decodeURIComponent(rest.replace(/\+/g, ' '));
|
Ran into this myself. I appended a similar patch that is a bit more invasive but keeps the undefined values as before. See comments in |
PerLindenAddiva
referenced
this pull request
Sep 19, 2014
Currently if there are any '=' in the value of a param it will get
improperly split.
?token=1234==
Becomes
{ token: "1234" }
This fix should only split on the first instance. So the above example
should look like:
{ token: "1234==" }
|
Landed in branch Next-Version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #552