Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flake. #15654

Merged
merged 7 commits into from
Mar 3, 2025
Merged

Fix test flake. #15654

merged 7 commits into from
Mar 3, 2025

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Mar 3, 2025

Description

We've had a flake that's caused by an attempt to store JSON inside of a CSV by replacing the double quotes with single quotes, e.g.

"{ 'hello': 'world' }"

Which works great, until you want to store a value with a real single quote in it:

"{ 'hello': 'world's' }"

Because now when we try to parse that by switching the single quotes back out for double quotes, we get invalid JSON:

{ "hello": "world"s" }

I've fixed this by doing proper CSV double-quote escaping on the encoded JSON string.

@samwho samwho requested a review from a team as a code owner March 3, 2025 11:29
@samwho samwho requested review from mike12345567 and removed request for a team March 3, 2025 11:29
Copy link

qa-wolf bot commented Mar 3, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Mar 3, 2025
@samwho samwho enabled auto-merge March 3, 2025 22:33
@samwho samwho merged commit 2c43740 into master Mar 3, 2025
21 checks passed
@samwho samwho deleted the fix-flake-3 branch March 3, 2025 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants