Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert middleware tests to TS, remove mocks. #15686

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Mar 6, 2025

Description

It appeared that selfhost.ts middleware was no longer used, so I deleted it and its tests.

@samwho samwho requested a review from a team as a code owner March 6, 2025 15:12
@samwho samwho requested review from adrinr and removed request for a team March 6, 2025 15:12
Copy link

qa-wolf bot commented Mar 6, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Mar 6, 2025
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samwho samwho enabled auto-merge March 11, 2025 15:02
@samwho samwho merged commit 623effe into master Mar 11, 2025
22 checks passed
@samwho samwho deleted the migrate-js-to-ts-1 branch March 11, 2025 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants