Fix S3 integration custom endpoints usage

[CSLTech]

Description

Custom S3 endpoints are broken. This fixes the S3 integration usage of custom S3 endpoints

Addresses

• Custom S3 Endpoints broken #15700

Launchcontrol

Fix S3 integration when using custom endpoints

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[samwho]

Hey @CSLTech, thanks for the contribution!

I'll get this merged when the tests pass.

[samwho]

Actually, @mike12345567 pointed out to me that folks may have set this to invalid values and forgotten they've done it since it does nothing right now. Enabling this could break them.

What we'd like to do is introduce a new config parameter called customEndpoint, and deprecate this endpoint parameter. Would you be able to make this change?

What you need to do is add deprecated: true to the config entry in the SCHEMA on line 45. Then add a new customEndpoint to the schema, as well as the to S3Config type above the schema. Then plumb it in like you did with config.endpoint 🙏

[CSLTech]

Ermm, I can make the change, but this should be somewhat documented as this PR in it's current state fixes an issue that is a regression from a working behavior. Moreover if they had it misconfigured it would have made the signed links behave in a (Most likely broken) weird way.

[samwho]

@CSLTech Apologies, you're right. I misunderstood the situation. Thank you for noticing and fixing this!