PWA Support #15759
PWA Support #15759
Conversation
PClmnt
added
the
feature-branch-enterprise
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
PClmnt
added
feature-branch-enterprise
| export async function enrichPWAImages( | ||
| images: PWAManifestImage[] | ||
| ): Promise<PWAManifestImage[]> { | ||
| if (!images || images.length === 0) { |
There was a problem hiding this comment.
The parameter is not optional, so either this !images is not needed or we should make the param optional
packages/bbui/src/Form/File.svelte
Outdated
| @@ -12,7 +12,8 @@ | |||
| export let extensions: string[] | undefined = undefined | |||
| export let error: string | undefined = undefined | |||
| export let title: string | undefined = undefined | |||
| export let value: File | undefined = undefined | |||
| export let value: File | { name: string; type: string } | undefined = | |||
There was a problem hiding this comment.
This does not match the core one, as it does not have size. Is that needed?
| } | ||
|
|
||
| async function handlePWAZip(file: File) { | ||
| if (!file) return |
There was a problem hiding this comment.
Should this display an error?
| @@ -243,8 +327,45 @@ export const serveApp = async function (ctx: UserCtx<void, ServeAppResponse>) { | |||
|
|
|||
| const { head, html, css } = AppComponent.render({ props }) | |||
| const appHbs = loadHandlebarsFile(appHbsPath) | |||
|
|
|||
| let extraHead = "" | |||
| const pwaEnabled = true // await pro.features.isPWAEnabled() | |||
There was a problem hiding this comment.
This needs to be properly set
There was a problem hiding this comment.
I can't add the license on the feature branch right now as account portal has stopped deploys, so this is just temporary.
| icon => icon.sizes === "1240x600" || icon.sizes === "2480x1200" | ||
| ) | ||
| if (desktopScreenshot) { | ||
| manifest.screenshots?.push({ |
There was a problem hiding this comment.
This will not push the object if screenshots is undefined. Is this what you are attempting?
Otherwise, you would need to ensure that manifest.screenshots exists: manifest.screenshots ??= []
| @@ -57,7 +58,16 @@ | |||
| <!-- svelte-ignore a11y-no-static-element-interactions --> | |||
| <!-- svelte-ignore a11y-click-events-have-key-events --> | |||
| <div class="field"> | |||
| {#if value} | |||
| {#if statusText} | |||
There was a problem hiding this comment.
Needed a state for the File component where it didn't take a File type, just some text. And I thought this was cleaner than mixing types on the value prop.
| @@ -94,3 +94,21 @@ export function checkForCollectStep(automation: Automation) { | |||
| step => step.stepId === ActionStepID.COLLECT | |||
| ) | |||
| } | |||
|
|
|||
| export function rgbToHex(rgbStr: string | undefined): string { | |||
There was a problem hiding this comment.
You might want to add this to BBUI helpers instead - there's already a hexToRGBA helper there, so this would make sense to go alongside it since it's the inverse.
| @@ -34,6 +34,13 @@ import { APIClient } from "@budibase/frontend-core" | |||
| import BlockComponent from "./components/BlockComponent.svelte" | |||
| import Block from "./components/Block.svelte" | |||
|
|
|||
| if (typeof window !== "undefined") { | |||
There was a problem hiding this comment.
Looks totally fine but I'd just add a one liner comment above this explaining whats happening 👍
Description
Adds the ability to enable PWA apps for your Budibase application on Enterprise tier.
Addresses
https://linear.app/budibase/issue/BUDI-9178/pwa-support
Screenshots
Settings
Unlicensed
Install prompt web
Install prompt mobile
Icon on mobile home screen
Splash screen upon opening app
App opened
Install button on desktop
Installing via button on phone
qqqq.mov
Launchcontrol
Feature branch env
Feature Branch Link