MySQL ANSI quotes support for queries #15795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s allowed by default in MySQL.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
approved these changes
Mar 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In MySQL by default constant character strings can be input as
"String"or'String'- this was causing issues in our binding system.This fix addresses the issue defined here: #15778
If
ANSI_QUOTESare disabled then in theory we will try to replace bindings within identifier strings but bindings in these situations do not work anyway so either case will be an error.