Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pro package resolutions #15799

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Fix pro package resolutions #15799

merged 2 commits into from
Mar 24, 2025

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Mar 24, 2025

Description

Budibase has a submodule pro that is required to run Budibase, but it's not publicly available. To solve this, we used a "hack" to resolve that package from npm. Yarn workspace would load this npm package if the submodule is not loaded, and use the local one otherwise. This allows us as BB devs to work with everything locally, while OSS contributors can also run it locally without having access to the protected submodule.

For some reason, it looks like this stopped working, as the yarn workspace is now symlinking to the root of the project, but the pro version coming from npm is hoisted on the packages that use them.

This PR is moving the resolutions to the actual packages, keeping everything working as it used to. Not sure what changed the previous behaviour, but this now works as expected. I also tried using [nohoist](https://classic.yarnpkg.com/blog/2018/02/15/nohoist/), but for some reason I could not get it working.

Copy link

qa-wolf bot commented Mar 24, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Mar 24, 2025
@adrinr adrinr marked this pull request as ready for review March 24, 2025 15:46
@adrinr adrinr requested a review from a team as a code owner March 24, 2025 15:46
@adrinr adrinr requested review from mike12345567 and removed request for a team March 24, 2025 15:46
@adrinr adrinr enabled auto-merge March 24, 2025 15:49
@adrinr adrinr merged commit 9364aa5 into master Mar 24, 2025
22 checks passed
@adrinr adrinr deleted the chore/fix-pro-hoisting-issues branch March 24, 2025 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants