Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Budibase has a submodule
pro
that is required to run Budibase, but it's not publicly available. To solve this, we used a "hack" to resolve that package from npm. Yarn workspace would load this npm package if the submodule is not loaded, and use the local one otherwise. This allows us as BB devs to work with everything locally, while OSS contributors can also run it locally without having access to the protected submodule.For some reason, it looks like this stopped working, as the yarn workspace is now symlinking to the root of the project, but the pro version coming from npm is hoisted on the packages that use them.
This PR is moving the resolutions to the actual packages, keeping everything working as it used to. Not sure what changed the previous behaviour, but this now works as expected. I also tried using
[nohoist](https://classic.yarnpkg.com/blog/2018/02/15/nohoist/)
, but for some reason I could not get it working.