Some typings created during the oauth2 work #15812
Open
+112
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
approved these changes
Mar 26, 2025
| @@ -764,7 +764,7 @@ if (descriptions.length) { | |||
| const verbs = ["read", "create", "update", "delete"] | |||
| for (const verb of verbs) { | |||
| const query = await createQuery({ | |||
| fields: { json: {}, extra: { actionType: "invalid" } }, | |||
| fields: { json: {}, extra: { actionType: "invalid" as any } }, | |||
There was a problem hiding this comment.
I tend to prefer throwing a // @ts-expect-error in these cases because it makes it more explicit, you can explain you're testing an invalid value on purpose. Also at some point I'd love to start tracking the count of any in the codebase and aim toward 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert some files around rest picker