Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/gap open item #937

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Fix/gap open item #937

merged 3 commits into from
Jun 27, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Jun 26, 2023 •
edited
Loading

DEVELOP

  • OpenPositionItem
  • OpenSubTab
  • PositionLineGraph
  • /constants/cfd_state_code.ts

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 3:08am

@arealclimber arealclimber self-assigned this Jun 26, 2023
This was linked to issues Jun 26, 2023
[BUG] Gap between price point and line graph on Open Item #922
Closed
[BUG] Sorting logic on Open tab #936
Closed
@arealclimber arealclimber marked this pull request as ready for review June 26, 2023 09:04
Luphia
Luphia approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 2693f0a into develop Jun 27, 2023
@Luphia Luphia deleted the fix/gap-open-item branch June 27, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Sorting logic on Open tab [BUG] Gap between price point and line graph on Open Item
2 participants
@arealclimber @Luphia