Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-2299 Accessibility: Avoid skipping heading levels (footer) #21

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

dhgreene
Copy link
Contributor

Fixes BCDA-2299

Screen readers don't like heading levels to be skipped. We can adjust our footer to that best practice without visible change.

Proposed Changes

  • Change footer headings to <h2>

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications

No data has been exposed in this documentation change.

Acceptance Validation

No visible change in footer ("CMS & HHS Websites" and "Additional resources")

Screen Shot 2019-12-30 at 3 53 56 PM

Feedback Requested

Any concerns?

@dhgreene dhgreene requested a review from msnook December 30, 2019 21:00
@dhgreene dhgreene changed the title BCDA-2299 Accessibility: Accessibility: Avoid skipping heading levels (footer) BCDA-2299 Accessibility: Avoid skipping heading levels (footer) Dec 31, 2019
@dhgreene dhgreene merged commit c187d7b into master Dec 31, 2019
@dhgreene dhgreene deleted the dhg/BCDA-2299 branch December 31, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants