Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-2308 Accessibility: Remove contentinfo role in footer #26

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

dhgreene
Copy link
Contributor

Fixes BCDA-2308

Explicitly setting the footer to the contentinfo role is redundant, as assistive technology will set it automatically.

Proposed Changes

  • Remove the contentinfo role in the footer

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications

No data has been exposed in this documentation change.

Acceptance Validation

Screen Shot 2020-01-27 at 7 33 18 PM

Feedback Requested

  • Any suggestions?

Sorry, something went wrong.

@dhgreene dhgreene requested review from epfrankle and tbellj January 28, 2020 00:37
Copy link
Contributor

@tbellj tbellj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! is there some supporting document stating how these changes are 508 compliant? Not a big deal just curious.

@dhgreene
Copy link
Contributor Author

Nice! is there some supporting document stating how these changes are 508 compliant? Not a big deal just curious.

@tbellj The support is in each ticket. Principles are referenced, but largely we're trusting the expert who wrote the tickets.

@dhgreene dhgreene merged commit 46f505d into master Jan 28, 2020
@dhgreene dhgreene deleted the dhg/BCDA-2308 branch February 18, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants