BCDA-2312 Accessibility: Do not duplicate credential elements #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BCDA-2312
Our nifty button to copy client ID's/secrets from the user guide has an accessibility flaw: it has a hidden duplicate input element, to make copying easier.
This PR does away with the input element, and thus the duplication, accepting the challenge goal of the ticket and sidestepping the original request (to add
<label>
tags for the input).Proposed Changes
copyText()
function to not need an input elementSecurity Implications
The Javascript function touches security credentials, albeit publicly published credentials. However, there is no effective change in security posture with the script changes.
Acceptance Validation
Feedback Requested
Please try this in multiple browsers!