Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-2312 Accessibility: Do not duplicate credential elements #31

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

dhgreene
Copy link
Contributor

Fixes BCDA-2312

Our nifty button to copy client ID's/secrets from the user guide has an accessibility flaw: it has a hidden duplicate input element, to make copying easier.

This PR does away with the input element, and thus the duplication, accepting the challenge goal of the ticket and sidestepping the original request (to add <label> tags for the input).

Proposed Changes

  • Change the copyText() function to not need an input element

Security Implications

  • new software dependencies
  • security controls or supporting software altered
  • new data stored or transmitted
  • security checklist is completed for this change
  • requires more information or team discussion to evaluate security implications

The Javascript function touches security credentials, albeit publicly published credentials. However, there is no effective change in security posture with the script changes.

Acceptance Validation

BCDA copy script

Feedback Requested

Please try this in multiple browsers!

Copy link
Contributor

@msnook msnook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking PR Acceptance Validation section to the next level. 💯

@dhgreene dhgreene merged commit 014a71a into master Feb 21, 2020
@dhgreene dhgreene deleted the tbell/BCDA-2312 branch February 21, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants